View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0001826 | K18X001.00 SKB SWAN | SW | public | 2023-11-02 13:46 | 2024-01-23 10:37 |
| Reporter | (ALTech) Sangmin Choi | Assigned To | (ALTech) Sangmin Choi | Due Date | 2023-11-08 13:14 |
| Priority | normal | Severity | s4-minor | Reproducibility | always |
| Status | closed | Resolution | reopened | ||
| Summary | 0001826: The sound is too loud under tunneled playback. | ||||
| Description | SKB services the VOD as HLS and it plays as tunneled. When I play the HLS VOD the sound is too loud compared with Live sound. Now, the HLS VOD services as default. You can see the following log message when you play the HLS VOD. 130|BFX-UA300:/ # logcat | grep "isHls is" 11-02 14:44:16.484 1697 1697 I VODPlayerUtils: isHls is true 11-02 14:44:16.513 1697 1697 I VODPlayerUtils: isHls is true 11-02 14:44:20.391 1697 1697 I VODPlayerUtils: isHls is true Could you please check this issue? This issue is discussed in following jira. https://jira.skbroadband.com/browse/BTVV-6883 Thank you. | ||||
| Tags | No tags attached. | ||||
| Attach Tags | |||||
| User List |
(ALTech) Wooshin Kang , |
|---|
|
|
Hello, Jason, Could you please check this issue? Thank you. Sangmin Choi. |
|
|
Hello, Jerry, I think I found something, please stop checking this issue. I will let you know it's helpful. Thank you. Sangmin Choi. |
|
|
Hello, Jerry and Jason, When I change the volume, the called Synaptics AMP function is different with Live and HLS VOD. // Live vendor/synaptics/btv-hal-impl/synaptics/hal_av_pipeline.c -> AVP_SetMediaAudioVolume(AVP_HANDLE player, int volume, float gain) -> AMP_SND_SetStreamVolumeIndB is called // HLS VOD vendor/synaptics/vsxxx/audio/AudioStreamTunnelOut.cpp -> AudioStreamTunnelOut::setVolume(float left, float right) -> AudioStreamTunnelOut::setVolume(UINT32 volume) -> AMP_SND_SetStreamVolume is called So, the output sound is different because they called different function with different parameter. To fix this issue, in HLS VOD playback, AMP_SND_SetStreamVolume function should be changed to AMP_SND_SetStreamVolumeIndB. And, also calculating correct volume gain from input parameters(float left, float right) is required. Could you please check it? Thank you. Sangmin Choi. |
|
|
And, I have one more question. Do you know why (float left, float right) parameters were passed when I change the volume in HLS VOD? |
|
|
Hi Sangmin, I check with the follwoing commits in vendor/synaptics/btv-hal-impl/synaptics/hal_av_pipeline.c. 1. 15496b6304853261d844caddd5faaa5646daada1 2. e48377383d107e17ae9f799a697509d7be18a8dc 3. 4082cfb662d3d084b2adc079feb17710d0956f6e 4. 2f5b13179fb7c773701fdacfc1780e8254539f21 It seems to read gain value from /btv_home/config/media_volume.dat and add the gain value to AMP_SND_SetStreamVolumeIndB. Please help to confirm with SPtek. Can this gain value also added in vendor/synaptics/vsxxx/audio/AudioStreamTunnelOut.cpp. Please help to confim this commit ( 2f5b13179fb7c773701fdacfc1780e8254539f21 ) with SPtek, This commit remove AMP_SND_SetStreamVolume(). Maybe this modifcation cause this issue happened. Jerry |
|
|
Hello, Jerry, Please help to confim this commit ( 2f5b13179fb7c773701fdacfc1780e8254539f21 ) with SPtek, This commit remove AMP_SND_SetStreamVolume(). Maybe this modifcation cause this issue happened. -> I removed that commit, but the issue has also reproduced.(HLS VOD sound is louder than Live) I think my analysis disturbs you to figure out the cause correctly. Please ignore my comment(0014453) and please check why the HLS VOD sound is louder than Live. Thank you. Sangmin Choi. |
|
|
Hello, Jerry, Could you please let me know if there is any update? Thank you. Sangmin Choi. |
|
|
Hello, Jerry, Could you please let me know if there is any update? Thank you. Sangmin Choi. |
|
|
Hi Sangmin, I will share you test FW today. I read the gain value from /btv_home/config/media_volume.dat and apply to AMP_SND_SetStreamVolumeIndB(). Jerry |
|
|
Hello, Jerry, Thank you. Please prepare the test firmware based on 540 branches. Best Regards, Sangmin Choi. |
|
|
Hi Sangmin Choi, upload to /release_by_fxn/swan_test_image/20231121_mantis1826/usb_bfx-ua300_V19.540.22_SD.zip Jerry |
|
|
Hello, Jerry, Please apply this modification to 541 branches. And, please add "[BPM-25848]" to the prefix of commit message. Thank you. Sangmin Choi. |
|
|
Hi Sangmin Choi , commit finished. 2023-11-27 17:48:36 | liang-chyi.lin@fii.. | 5505072 | vendor/synaptics/vsxxx | [BPM-25848] The sound is too loud under tunneled playback. [2/2] 2023-11-27 17:47:54 | liang-chyi.lin@fii.. | 19acc0c | device/synaptics/sequoia | [BPM-25848] The sound is too loud under tunneled playback. [1/2] Jerry |
|
|
Hello, Jerry, Thank you for support. |
|
|
Hello, Jerry, There is no fclose in AudioStreamTunnelOut::setVolume function. So, the file descriptor is increased when I change the volume in HLS VOD. audio@2.0-servi 349 audioserve 93r REG 179,22 8 106 /btv_home/config/media_volume.dat audio@2.0-servi 349 audioserve 94r REG 179,22 8 106 /btv_home/config/media_volume.dat audio@2.0-servi 349 audioserve 95r REG 179,22 8 106 /btv_home/config/media_volume.dat audio@2.0-servi 349 audioserve 96r REG 179,22 8 106 /btv_home/config/media_volume.dat audio@2.0-servi 349 audioserve 97r REG 179,22 8 106 /btv_home/config/media_volume.dat audio@2.0-servi 349 audioserve 98r REG 179,22 8 106 /btv_home/config/media_volume.dat Could you please add fclose in AudioStreamTunnelOut::setVolume function? Thank you. Sangmin Choi. |
|
|
Hi Sagngmin , Which prefix for this issue ? Jerry |
|
|
Hello, Jerry, Please use "[BPM-28194]". Thank you. |
|
|
This issue was fixed. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2023-11-02 13:46 | (ALTech) Sangmin Choi | New Issue | |
| 2023-11-02 13:46 | (ALTech) Sangmin Choi | Status | new => assigned |
| 2023-11-02 13:46 | (ALTech) Sangmin Choi | Assigned To | => (SW) Jason Ling |
| 2023-11-02 13:51 | (ALTech) Sangmin Choi | Note Added: 0014450 | |
| 2023-11-02 13:51 | (ALTech) Sangmin Choi | Due Date | 2023-11-06 13:14 => 2023-11-08 13:14 |
| 2023-11-02 14:06 |
|
Assigned To | (SW) Jason Ling => (SW) Jerry Lin |
| 2023-11-02 15:14 | (ALTech) Sangmin Choi | Note Added: 0014451 | |
| 2023-11-02 16:34 | (ALTech) Sangmin Choi | Note Added: 0014453 | |
| 2023-11-03 08:52 | (ALTech) Sangmin Choi | Note Added: 0014460 | |
| 2023-11-03 13:38 |
|
Issue Monitored: (SW) Jason Ling | |
| 2023-11-06 10:09 | (SW) Jerry Lin | Note Added: 0014472 | |
| 2023-11-07 12:37 | (ALTech) Sangmin Choi | Note Added: 0014486 | |
| 2023-11-13 15:52 | (ALTech) Sangmin Choi | Note Added: 0014517 | |
| 2023-11-20 14:24 | (ALTech) Sangmin Choi | Issue Monitored: (ALTech) Wooshin Kang | |
| 2023-11-20 14:24 | (ALTech) Sangmin Choi | Note Added: 0014588 | |
| 2023-11-21 08:27 | (SW) Jerry Lin | Note Added: 0014592 | |
| 2023-11-21 10:04 | (ALTech) Sangmin Choi | Issue Monitored: (ALTech) Yoonjoo Lim | |
| 2023-11-21 10:06 | (ALTech) Sangmin Choi | Note Added: 0014596 | |
| 2023-11-21 10:29 | (SW) Jerry Lin | Note Added: 0014597 | |
| 2023-11-21 10:43 | (ALTech) Sangmin Choi | Issue End Monitor: (ALTech) Yoonjoo Lim | |
| 2023-11-27 13:40 | (ALTech) Sangmin Choi | Note Added: 0014631 | |
| 2023-11-27 17:49 | (SW) Jerry Lin | Note Added: 0014636 | |
| 2023-11-28 08:26 | (ALTech) Sangmin Choi | Note Added: 0014639 | |
| 2023-11-28 08:27 | (ALTech) Sangmin Choi | Assigned To | (SW) Jerry Lin => (ALTech) Sangmin Choi |
| 2023-11-28 08:27 | (ALTech) Sangmin Choi | Status | assigned => closed |
| 2023-11-28 08:27 | (ALTech) Sangmin Choi | Resolution | open => fixed |
| 2024-01-22 11:18 | (ALTech) Sangmin Choi | Assigned To | (ALTech) Sangmin Choi => (SW) Jerry Lin |
| 2024-01-22 11:18 | (ALTech) Sangmin Choi | Status | closed => feedback |
| 2024-01-22 11:18 | (ALTech) Sangmin Choi | Resolution | fixed => reopened |
| 2024-01-22 11:18 | (ALTech) Sangmin Choi | Note Added: 0014989 | |
| 2024-01-22 13:33 | (SW) Jerry Lin | Note Added: 0014992 | |
| 2024-01-22 13:48 | (ALTech) Sangmin Choi | Note Added: 0014993 | |
| 2024-01-22 13:48 | (ALTech) Sangmin Choi | Status | feedback => assigned |
| 2024-01-23 10:37 | (ALTech) Sangmin Choi | Assigned To | (SW) Jerry Lin => (ALTech) Sangmin Choi |
| 2024-01-23 10:37 | (ALTech) Sangmin Choi | Status | assigned => closed |
| 2024-01-23 10:37 | (ALTech) Sangmin Choi | Note Added: 0014998 |
